Module talk:Title

From Wikimedia Commons, the free media repository
Jump to navigation Jump to search

Protected edit

[edit]

{{requested edit}} Files such as File:Edouard Manet 032.jpg that use this template do not seem to allow the interface to recognize that a particular language is being used. On File:Edouard Manet 032.jpg, there is an English title and my default language is set to English, and yet, I see "This image does not appear to have a description in your interface language. Please add one!" Were the module to insert {{en|1=}}, the site would recognize that there is an English-language title (see, e.g. this revision, which does not have the error message). Please edit the module so that {{Title}} will insert these language-specific templates whenever a title in a given language is used. —Justin (koavf)TCM 23:56, 7 April 2022 (UTC)[reply]

Koavf, I can't reproduce any problem, for me also this version looks just fine. As it is not clear which specific edit should be made I've deactivated {{Edit request}} for now. Best, --Marsupium (talk) 20:54, 16 April 2022 (UTC)[reply]
It's fine now. Weird. Thanks. —Justin (koavf)TCM 20:55, 16 April 2022 (UTC)[reply]

require('strict')

[edit]

{{Edit protected}} As per the new lua feature mentioned at m:Tech/News/2022/42, could require('Module:No globals') be replaced with require('strict') -- WOSlinker (talk) 17:26, 25 October 2022 (UTC)[reply]

✓ Done Jonesey95 (talk) 16:11, 26 October 2022 (UTC)[reply]

Block element div

[edit]

{{Edit request}}

Recently modification from span to div causes some problems, because div is a block element and span isn't. So please change back to span or add style='display: inline-block' to the div element. Thank you. --XRay 💬 09:04, 9 November 2022 (UTC)[reply]

@Jonesey95: , FYI. —Justin (koavf)TCM 09:14, 9 November 2022 (UTC)[reply]
In one case I found a solution. I've changed it to <div style="display:inline-block">{{Title|...}}</div>. --XRay 💬 13:12, 9 November 2022 (UTC)[reply]
Can you please link to a page where the new code causes a difference in rendering? Thanks. Jonesey95 (talk) 14:08, 9 November 2022 (UTC)[reply]
I made this change: Revision of 703998533. And this is an example with the different rendering:
Sculpture:
German:
Beispiel

Sample
title QS:P1476,de:"Beispiel"
label QS:Lde,"Beispiel"
label QS:Len,"Sample"
 
Title
German:
Beispiel

Sample
title QS:P1476,de:"Beispiel"
label QS:Lde,"Beispiel"
label QS:Len,"Sample"
Artist Unknown artist
Date 2022

--XRay 💬 14:25, 9 November 2022 (UTC)[reply]

Thank you for the example. Many of the difficult remaining Linter errors on Commons come from people putting div or span tags where they do not belong, or wrapping or preceding them with inappropriate markup. I have added display:inline-block to this module, which appears to resolve the problem you described above. I have also fixed the markup in {{Object description}} to prevent {{Title}} from being wrapped in italic and bold markup, which causes errors. Jonesey95 (talk) 21:05, 10 November 2022 (UTC)[reply]
Thank you. --XRay 💬 04:50, 11 November 2022 (UTC)[reply]